Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cubesql): Fix SELECT DISTINCT on pushdown #9144

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix(cubesql): Fix SELECT DISTINCT on pushdown #9144

wants to merge 10 commits into from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 27, 2025 •
edited
Loading

This PR fixes correct Cube query generation for SELECT DISTINCT xxxx queries via SQL API.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.98477% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (d130dbc) to head (84fdb24).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/members.rs 96.15% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9144      +/-   ##
==========================================
+ Coverage   83.07%   83.11%   +0.03%     
==========================================
  Files         226      226              
  Lines       79607    79802     +195     
==========================================
+ Hits        66136    66329     +193     
- Misses      13471    13473       +2
Flag Coverage Δ
cubesql 83.11% <98.98%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon force-pushed the fix/select-distinct branch from 62aefac to b9cf2bb Compare January 27, 2025 18:51
@KSDaemon KSDaemon marked this pull request as ready for review January 27, 2025 21:29
@KSDaemon KSDaemon requested a review from a team as a code owner January 27, 2025 21:29
@KSDaemon KSDaemon force-pushed the fix/select-distinct branch from f326180 to 3316caf Compare January 27, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KSDaemon